View source for Software ECO process

{{OLPC}}
{{Developers}}

==Patch Release Process==
From time to time there may be critical bug fixes that must be released before the next normal, scheduled releases. These can occur due to security issues, from unexpected hardware problems, or the discovery of latent bugs that affect large numbers of users. Please review the [[Patch_Criteria|Patch Criteria]] to see if a bug fixes fall into a typical category.

===Process Steps:===

# [[#ECO REQUEST|ECO REQUEST]]: Anyone who sees a problem they believe to be critical can initiate the email <font color="red">to whom?</font> to start this discussion. Please fill in as much as possible of the information requested [#ECO REQUEST|below]]. (The request should include a reference to an ECO page in the wiki (See [[OLPC_SW-ECO_2]] as an example);
# [[#REVIEW|REVIEW]]: Once the request has been made, a request for a review of this ECO should be made by email <font color="red">to whom?</font>, which commits both development and testing resources to work on it;
# [[#TEST|TEST]]: Once a build is ready for testing, an announcement should be made; bug-specific tests as well as the [[1 hour smoke test]] should be conducted. The results of these tests should be included as part of the ECO wiki page;
#* Test results need to be announced before advancing to a signed build;
# [[#APPROVAL|APPROVAL]]: Appropriate people must approve of the ECO at this stage;
# [[#SIGNED BUILD/FINAL TEST|SIGNED BUILD/FINAL TEST]]: A signed build is created and must go through final test;
# [[#RELEASE|RELEASE]]: Releasing a patch includes notifying all appropriate parties with information on what they need to do to distribute/apply the patch;

==Steps==

===ECO REQUEST===

Proposals for patches should be submitted to the "software-eco" mailing list, with a Trac bug that links to any and all other trac bugs and a link to a wiki page that includes the following information. See [[OLPC_SW-ECO_2]] for an example:

* Title of Patch (should be a short description of the major driving force for this patch)
* Trac items: description of the issue
* Priority: the believed urgency of the fix, including any deadlines
* Root Cause: why did this occur
* Effect, user perspective: How many are affected? What does the user see, how does it affect them? Is there a work-around? Consequences of not fixing it
* Proposed Fix: the patch(s) for review, if not clearly stated in referenced bugs
* Reviewers: who has reviewed the patch(s) for correctness (preferably at least three people competent in the area affected)
* Proposed Testing: developer testing, QA testing, multi-language, boot up, upgrade testing, etc. 
* Proposed Rollout: Mfg, Support group, G1G1 users, country deployment teams, etc.

Discussion can then ensue in trac. If there is no consensus that the patch should be deployed, a decision will be made by Jim Gettys, Kim Quirk, and Walter Bender. 

Security patches cannot, unfortunately, follow this path due to disclosure rules, but will occur in a similar fashion on a closed security mailing list and additionally include Ivan Krstic in the decision.

===REVIEW===

The ECO must be reviewed and approved. The review approvers should include SW development (Jim), Testing (Kim), Security (Ivan), and Walter. Approval to work on this patch can be made via email.

===TEST===

The testing for this patch will include both specific and general tests. Once the release master has created a candidate (unsigned) for testing; the testers can go through the test plan.

'''Specific Testing'''
# The build will be tested using the information contained in the trac bug(s) to ensure specific fixes.

'''General Testing'''
# The build must be installed on MP and B4 systems successfully
# Upgrades from the previous release are successful
# A fresh install (as in manufacturing) is successful on both MP and B4 systems
# The [[1 Hour Smoke Test]] must be performed, both using a fresh installation and an upgraded installation, looking specifically for regressions from the release reports, and thinking about possible interactions a fix might cause. Fixes to core technologies may require much more extensive testing and soaking, as some failures only occur after time or use 
# More than one SKU and keyboard type are to be used during this testing, to catch regressions in keyboard identification.
# Any new hardware support must be tested explicitly (e.g. new keyboard type, new revision of a component).
# When time permits, test builds should be used for testing by developers in the field to confirm the fixes.

If <i>new</i> problems (not previously known as part of testing or bug reports) are discovered during the test process, they <b>must</b> be analyzed to root cause and the software-eco mailing list informed of the findings, and a new decision made on proceeding. These would normally be latent bugs, and the criterion for proceeding (waiving) the bug should be based on a judgment that the patch build is at a minimum no worse than the previous build

===APPROVAL===

After test results are in, the next step is to get approval of the build for signing. This approval should include a majority approval of the tester, the developer, Jim, Walter, Ivan, and Kim. 


===SIGNED BUILD/FINAL TEST===

Key in any signing decision should be, "does this build, or could this build, compromise antitheft/activation security"? Changes in the firmware, kernel, olpcrd could potentially compromise security; in general other changes are "safer".


'''Release Checklist'''
# Sign the build, generate known checksums, using the signature procedure.
# the build should be made available in the 'candidate' directory on download.laptop.org for release candidates.
# Was the correct version of OFW included in the build?
# Have the olpcrd, kernel, firmware changed?  These are central to our security system, and an additional audit is required by the security team, by different individuals than wrote the patch
# The testing of the patch release succeeded or a newly discovered problem waived (per above)
# All source packages are present and accounted for
# All packages were build on the correct OLPC controlled build system(s) 
# Only packages fixing the referenced bug(s) are changed by the build that is to be signed
# Whenever practical, the build will have also been tested by a significant number of users in the field to confirm the fixes are correct.

The build master is responsible for ensuring the checklist and that the process has been followed. 


'''Testing'''
# The signed build needs to be installed on a write-protected laptop via USB stick - fresh install as well as upgrade
# The signed build needs to be upgrade from the previous stable build via network update.
# The signed build must be automatically upgraded from a central server.


Signing a release requires a majority quorum of: Jim Gettys, Walter Bender, Kim Quirk, Dennis Gilmore and Ivan Krstic.


===RELEASE===
Note that signing the build for release is <b>not</b> the end of the process: the signed release must see a final verification step on write protected systems.

The final steps are to be performed after the SIGNED BUILD TEST has been complete:

# Move the build from 'candidate' to 'official' on download.laptop.org.
# Notify the Quanta ECO mailing list, if indicated, preferably using signed email, and certainly containing checksums of the build and the URL at which the official bits can be found. Can this be phased in? Or must be done as quickly as possible?
# Notify the Software-eco and devel mailing lists that this new build is available providing the link to the wiki page as release notes (or create a release notes page).