Talk:Speak: Difference between revisions
Jump to navigation
Jump to search
No edit summary |
No edit summary |
||
Line 7: | Line 7: | ||
* The mouth doesn't close all the way at the end of a sentence. |
* The mouth doesn't close all the way at the end of a sentence. |
||
* It looks like you're already aware of the occasional stutters. |
* It looks like you're already aware of the occasional stutters. |
||
* One mouth corner is drawn differently from the other; setting cairo to use rounded path joins might look a little better. |
* One mouth corner is drawn differently from the other; setting cairo to use rounded path joins and caps might look a little better. |
||
—[[User:Leejc|Joe]] 00:28, 10 January 2008 (EST) |
—[[User:Leejc|Joe]] 00:28, 10 January 2008 (EST) |
Revision as of 05:32, 10 January 2008
Some feedback
Nice job! This is fun to play with and extremely cute. I love that the activity speaks the options as you change them. Some minor points:
- The XEyes thing is great, but the distance between the two eyes means that for some screen positions one pupil is unrealistically off-level from the other. I'd recommend using the same y coordinate for both eyes; the average of the y coordinates that you are currently using should work.
- It looks like you're updating the eyes on a timer. I suspect that it might be more CPU efficient to just forward the mouse motion events from the widget's parent, but I don't know enough about gtk to know if there are any obvious drawbacks to this approach.
- The mouth doesn't close all the way at the end of a sentence.
- It looks like you're already aware of the occasional stutters.
- One mouth corner is drawn differently from the other; setting cairo to use rounded path joins and caps might look a little better.
—Joe 00:28, 10 January 2008 (EST)