Libertas todo

From OLPC
Revision as of 19:20, 10 October 2006 by 201.89.24.47 (talk)
Jump to navigation Jump to search

TODO list for Marvell 8388 wireless driver

Marcelo Tosatti

  • ioctl mess
  • 64-bit issues
  • proper locking: add a simple global mutex.
  • kernel style documentation (Documentation/kernel-doc-nano-HOWTO.txt)
  • collapse command queueing (remove queueing should simplify complexity a lot)
  • test individual suspend/resume (CONFIG_USB_SUSPEND)
  • multiple rdmac commands from ioctl (wlanconfig) causes driver to detect device as "removed"
  • reloading the firmware can crash the machine after power up (reloading code)

David Woodhouse

  • #ifdef __KERNEL__ in wlan_scan.h? !!
  • lots of typedef struct { ... } foo
    • most of them removed, a few remaining (marcelo)
  • __attribute__ ((packed)) wlan_ioctl_user_scan_cfg why packet?
    • some packed attributes are useless, some are not. We removed some already, need to finish (marcelo)
  • and if it's for compatibility with hardware, the u64 should be either __le64 or __be64

Dan Williams

  • confused at IsNetworkCompatible() in wlan_scan.c
  • Break current SIOC*IWENCODE into SIOC*IWENCODE, SIOC*IWENCODEEXT, SIOC*IWAUTH
  • Implement SIOC*IWGENIE
  • Make driver do deferred assocation rather than blocking on assoc in WE handlers like SIOCSIWENCODE